Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup and expand architecture page #7704

Merged
merged 1 commit into from
Feb 28, 2024
Merged

cleanup and expand architecture page #7704

merged 1 commit into from
Feb 28, 2024

Conversation

csplinter
Copy link
Member

These changes include

  1. Adding Components breakdown to the EKS Anywhere Architecture page
  2. Cleaning up the descriptions of standalone and management cluster deployment architectures

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (4583834) to head (796690b).
Report is 145 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7704      +/-   ##
==========================================
+ Coverage   73.48%   73.60%   +0.12%     
==========================================
  Files         579      588       +9     
  Lines       36357    37150     +793     
==========================================
+ Hits        26718    27346     +628     
- Misses       7875     8013     +138     
- Partials     1764     1791      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csplinter csplinter requested a review from chrisnegus February 23, 2024 23:18
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit d540381 into aws:main Feb 28, 2024
8 checks passed
@csplinter
Copy link
Member Author

/cherrypick release-0.19

@eks-distro-pr-bot eks-distro-pr-bot mentioned this pull request Feb 28, 2024
Merged
@eks-distro-pr-bot
Copy link
Contributor

@csplinter: new pull request created: #7735

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxesn jaxesn jaxesn approved these changes

@chrisnegus chrisnegus Awaiting requested review from chrisnegus

Assignees

@jaxesn jaxesn

Labels
approved area/docs Documentation documentation lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csplinter @eks-distro-bot @eks-distro-pr-bot @jaxesn